From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] libxl: build fix
Date: Tue, 13 Apr 2010 13:49:44 +0200
Message-ID: <201004131349.45308.Christoph.Egger@amd.com>
References: <201004131216.16083.Christoph.Egger@amd.com>
	<19396.21435.748085.75231@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19396.21435.748085.75231@mariner.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tuesday 13 April 2010 13:21:31 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build fix"):
> > Attached patch makes libxl compile on NetBSD.
> > <sys/signal.h> is needed to get definition for SIGPIPE and SIG_IGN.
>
> <sys/signal.h> is not a standard header file.  It should be <signal.h>.
>
> Adding
>  #include <signal.h>
> would be correct.

On NetBSD, the SIG* defines are in <sys/signal.h> which is just
included by <signal.h>
On NetBSD, both works.

But you're right, the portable fix is the prefered one.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632