Re: [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tuesday 13 April 2010 09:45:44 am Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> When EEEPC_WMI=y and INPUT_SPARSEKMAP=m, the build fails,
> so make EEEPC_WMI depend on INPUT_SPARSEKMAP.
> 
> eeepc-wmi.c:(.text+0x28d1a9): undefined reference to `sparse_keymap_setup'
> eeepc-wmi.c:(.text+0x28d1f9): undefined reference to `sparse_keymap_free'
> eeepc-wmi.c:(.text+0x28d2e0): undefined reference to
> `sparse_keymap_report_event' eeepc-wmi.c:(.init.text+0x17069): undefined
> reference to `sparse_keymap_free' eeepc-wmi.c:(.exit.text+0x2bae):
> undefined reference to `sparse_keymap_free'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20100413.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20100413/drivers/platform/x86/Kconfig
> @@ -388,7 +388,7 @@ config EEEPC_LAPTOP
>  config EEEPC_WMI
>  	tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
>  	depends on ACPI_WMI
> -	depends on INPUT
> +	depends on INPUT && INPUT_SPARSEKMAP

"select INPUT_SPARSEKMAP" please - users should not be concerned about
such implementation details.

-- 
Dmitry