From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O1i6Z-0002tj-GE
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 11:32:47 -0400
Received: from [140.186.70.92] (port=42560 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O1i6V-0002qt-Hv
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 11:32:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1O1i6Q-0008AM-1B
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 11:32:43 -0400
Received: from mx20.gnu.org ([199.232.41.8]:4148)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1O1i6P-0008AH-TN
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 11:32:37 -0400
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1O1i6P-0004HX-7p
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 11:32:37 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG
Date: Tue, 13 Apr 2010 16:32:25 +0100
References: <4BB2053C.6000701@collabora.co.uk>
	<201004031606.26893.paul@codesourcery.com>
	<4BC482A6.4040504@collabora.co.uk>
In-Reply-To: <4BC482A6.4040504@collabora.co.uk>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201004131632.25820.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian Molton <ian.molton@collabora.co.uk>, Gerd Hoffmann <kraxel@redhat.com>

> So, rather than bike-shedding, how about making some kind of decision?

Ok, let me make this simple.

Features such as rate limiting and EGD protocol translation should not be part 
of individual device emulation. They are part of the host interface, not the 
guest machine.  If you really want these in qemu then they should be 
implemented as part of the chardev layer.

It may be a bit more work to implement these properly. However I'm not going 
to accept a half-assed implementation just because someone wrote it.


A direct result of this is that virtio-rng degenerates to a crippled virtual 
serial port. We already have a virtual serial port implementation designed for 
exactly this kind of application.  IMHO virtio-rng is a complete waste of time 
and space.

Paul