From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, hch@lst.de
Subject: [Qemu-devel] Re: [PATCH] block: Split bdrv_open
Date: Tue, 13 Apr 2010 20:20:33 +0200 [thread overview]
Message-ID: <20100413182033.GA6756@lst.de> (raw)
In-Reply-To: <1271083756-31269-1-git-send-email-kwolf@redhat.com>
On Mon, Apr 12, 2010 at 04:49:16PM +0200, Kevin Wolf wrote:
> bdrv_open contains quite some code that is only useful for opening images (as
> opposed to opening files by a protocol), for example snapshots.
>
> This patch splits the code so that we have bdrv_open_file() for files (uses
> protocols), bdrv_open() for images (uses format drivers) and bdrv_do_open() for
> the code common for opening both images and files.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> This patch applies on top of Christoph's RFC for the format/protocol split
I like this a lot. A few comments:
- why is bdrv_do_open below it's users in the code? I really hate
forward declarations of functions and they can usually be easily
avoided.
- a "do" a function name is not very meaningfull - what about
bdrv_open_common instead?
- doesn't the backing device handling only apply to image formats, too?
next prev parent reply other threads:[~2010-04-13 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 14:49 [Qemu-devel] [PATCH] block: Split bdrv_open Kevin Wolf
2010-04-13 18:20 ` Christoph Hellwig [this message]
2010-04-14 7:22 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413182033.GA6756@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.