All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, Mark Hurenkamp <mark.hurenkamp@xs4all.nl>
Subject: Re: radeon in dom0/ivtv in domU: irq 16 nobody cared
Date: Tue, 13 Apr 2010 15:10:05 -0400	[thread overview]
Message-ID: <20100413191005.GB9173@phenom.dumpdata.com> (raw)
In-Reply-To: <4BC4B84D.1040505@goop.org>

> Does the kernel get to know about the passed-through irqs?  I was
> thinking that at pass-through time it would install the handler in dom0
> on the irq (and all other domains sharing the irq), and then the handler
> could do that hypercall and return IRQ_HANDLED / IRQ_NONE accordingly.

That was my other thought. But that means that the handler has to
do a hypercall - which I thought is a bit too heavy handed considering we only need
to know whether it is shared only once. The fake irq handler gets
disabled if the domain is turned off/pci hotplug removed.

Currently the fake IRQ handler is installed on the IRQ that is requested
by the guest. So if the IRQ is not shared in Dom0, it still gets
inserted in (and it won't receive any interrupts since that IRQ line is
not shared with the domain 0).
> 
> > Anyhow, my test rig that has a couple of IRQ lines shared across (A Dell
> > Dimension something) various devices and is doing something wacky with
> > or without this patch where the interrupt lines on the IOAPIC get masked
> > (and only if a specific IRQ line gets shared - 17) and no interrupts get
> > sent to either Dom0 or DomU. Manually unmasking the IOAPIC starts the
> > flow of interrupts thought it becomes a storm. Not sure if it is just
> > faulty hardware or operator, so please consider the above code/branch completly
> > untested.
> >   
> 
> Hrm.  You could instrument Xen to see who's masking the interrupt.

<nods>Right now I am, digging through code to figure out how to make this
happen without inserting to much code in the handler which would have
slowed the machine to a crawl.

  reply	other threads:[~2010-04-13 19:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07 22:45 radeon in dom0/ivtv in domU: irq 16 nobody cared Mark Hurenkamp
2010-04-08  0:19 ` Konrad Rzeszutek Wilk
2010-04-08 17:37   ` Konrad Rzeszutek Wilk
2010-04-08 18:45     ` Jeremy Fitzhardinge
2010-04-13 13:18       ` Konrad Rzeszutek Wilk
2010-04-13 18:30         ` Jeremy Fitzhardinge
2010-04-13 19:10           ` Konrad Rzeszutek Wilk [this message]
2010-04-13 19:21             ` Jeremy Fitzhardinge
2010-04-08 23:47   ` Mark Hurenkamp
2010-04-09  0:10     ` Mark Hurenkamp
2010-04-13 12:57     ` Konrad Rzeszutek Wilk
2010-04-13 20:05       ` Mark Hurenkamp
2010-04-13 20:43         ` Jeremy Fitzhardinge
2010-04-17  0:38         ` Mark Hurenkamp
2010-04-19 14:08           ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100413191005.GB9173@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jeremy@goop.org \
    --cc=mark.hurenkamp@xs4all.nl \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.