From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amerigo Wang Subject: Re: [PATCH] fix sdev_rw_attr macro for scsi device sysfs entries Date: Wed, 14 Apr 2010 15:50:09 +0800 Message-ID: <20100414075009.GC4503@cr0.nay.redhat.com> References: <4BC55D72.7080301@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:36118 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123Ab0DNHqZ (ORCPT ); Wed, 14 Apr 2010 03:46:25 -0400 Content-Disposition: inline In-Reply-To: <4BC55D72.7080301@jp.fujitsu.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Tomohiro Kusumi Cc: "linux-scsi@vger.kernel.org" , linux-kernel@vger.kernel.org On Wed, Apr 14, 2010 at 03:15:14PM +0900, Tomohiro Kusumi wrote: >Hi > >This patch fixes sdev_rw_attr() macro for scsi device sysfs entries. >It seems there is no such function snscanf in the current linux kernel, Yes! Good catch! >so it fails to compile scsi driver when someone try to add a new rw entry. >This has been unfixed for a long time probably because current scsi device >has no rw entries. > Really? I compiled it in my configuration, but i don't see any compile error. Hmm, i think we are lucky, no one is using the macro sdev_rw_attr() currently. ># grep snscanf . -rn >./drivers/scsi/scsi_sysfs.c:489: snscanf (buf, 20, format_string, &sdev->field); \ > >Thanks, >Tomohiro Kusumi > > > >Signed-off-by: Tomohiro Kusumi Acked-by: WANG Cong Thanks!