From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Miles Lane <miles.lane@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: INFO: suspicious rcu_dereference_check() usage - include/linux/cgroup.h:492 invoked rcu_dereference_check() without protection!
Date: Wed, 14 Apr 2010 09:03:05 -0700 [thread overview]
Message-ID: <20100414160305.GE2516@linux.vnet.ibm.com> (raw)
In-Reply-To: <q2x7e0fb38c1004121144rb097e521hd2a7d8cea77c54b7@mail.gmail.com>
On Mon, Apr 12, 2010 at 02:44:56PM -0400, Eric Paris wrote:
> On Wed, Mar 10, 2010 at 11:28 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Sun, Mar 07, 2010 at 08:26:53PM -0500, Miles Lane wrote:
> >> [ 0.000000] Memory: 4004344k/5242880k available (5147k kernel code,
> >> 1084452k absent, 154084k reserved, 5943k data, 520k init)
> >> [ 0.000000] SLUB: Genslabs=13, HWalign=64, Order=0-3, MinObjects=0,
> >> CPUs=2, Nodes=1
> >> [ 0.000000]
> >> [ 0.000000] ===================================================
> >> [ 0.000000] [ INFO: suspicious rcu_dereference_check() usage. ]
> >> [ 0.000000] ---------------------------------------------------
> >> [ 0.000000] include/linux/cgroup.h:492 invoked
> >> rcu_dereference_check() without protection!
> >
> > Hello, Miles,
> >
> > This one is a false positive that is addressed by a set of boot-time
> > fixes that have recently gone into mainline, this series of commits:
> >
> > c598a070..71da8132
> >
> > Thanx, Paul
>
> I know you indicated this was fixed in mainline and I see that set of
> commits objects, but I'm seeing the below spew from linux-next today.
Thank you for checking on this, Eric. I am finally breaking down and
cloning linux-next, and will look into this.
Thanx, Paul
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> tag: next-20100412
> commit: bbeecf185fe464ccd7ee97ce6d3646ad686995b4
>
> [ 0.035602] ===================================================
> [ 0.036003] [ INFO: suspicious rcu_dereference_check() usage. ]
> [ 0.037006] ---------------------------------------------------
> [ 0.038004] include/linux/cgroup.h:533 invoked
> rcu_dereference_check() without protection!
> [ 0.039003]
> [ 0.039004] other info that might help us debug this:
> [ 0.039004]
> [ 0.040003]
> [ 0.040004] rcu_scheduler_active = 1, debug_locks = 0
> [ 0.041004] no locks held by swapper/0.
> [ 0.042003]
> [ 0.042004] stack backtrace:
> [ 0.043005] Pid: 0, comm: swapper Not tainted 2.6.34-rc3-next-20100412+ #65
> [ 0.044003] Call Trace:
> [ 0.045015] [<ffffffff8108584f>] lockdep_rcu_dereference+0xaf/0xc0
> [ 0.046010] [<ffffffff81044812>] set_task_cpu+0x2d2/0x370
> [ 0.047009] [<ffffffff814dfef5>] ? _raw_spin_unlock_irqrestore+0x65/0x80
> [ 0.048006] [<ffffffff81087aa0>] ? trace_hardirqs_on_caller+0x120/0x1a0
> [ 0.049006] [<ffffffff81087b2d>] ? trace_hardirqs_on+0xd/0x10
> [ 0.050006] [<ffffffff814dfed9>] ? _raw_spin_unlock_irqrestore+0x49/0x80
> [ 0.051005] [<ffffffff8104a7a6>] ? task_fork_fair+0xc6/0x390
> [ 0.052005] [<ffffffff810497b4>] sched_fork+0x74/0x170
> [ 0.053006] [<ffffffff81054a3f>] copy_process+0x62f/0x11e0
> [ 0.054006] [<ffffffff810882bd>] ? validate_chain+0x4fd/0x1360
> [ 0.055005] [<ffffffff810556ae>] do_fork+0xbe/0x3e0
> [ 0.056008] [<ffffffff81012519>] ? sched_clock+0x9/0x10
> [ 0.057008] [<ffffffff81077485>] ? sched_clock_local+0x15/0x80
> [ 0.058005] [<ffffffff810775ab>] ? sched_clock_cpu+0xbb/0xf0
> [ 0.059005] [<ffffffff81076415>] ? up+0x35/0x50
> [ 0.060005] [<ffffffff81083623>] ? get_lock_stats+0x23/0x70
> [ 0.061005] [<ffffffff8108367e>] ? put_lock_stats+0xe/0x30
> [ 0.062011] [<ffffffff81aa6e20>] ? kernel_init+0x0/0x2e0
> [ 0.063007] [<ffffffff810136dd>] kernel_thread+0x8d/0xa0
> [ 0.064007] [<ffffffff81aa6e20>] ? kernel_init+0x0/0x2e0
> [ 0.065009] [<ffffffff8100bc20>] ? kernel_thread_helper+0x0/0x10
> [ 0.066006] [<ffffffff81aa6140>] ? early_idt_handler+0x0/0x71
> [ 0.067006] [<ffffffff814c5cf1>] rest_init+0x21/0x110
> [ 0.068006] [<ffffffff81aa6d3f>] start_kernel+0x3af/0x490
> [ 0.069006] [<ffffffff81aa629c>] x86_64_start_reservations+0x7c/0xd0
> [ 0.070006] [<ffffffff81aa6000>] ? early_idt_handlers+0x0/0x140
> [ 0.071006] [<ffffffff81aa63e8>] x86_64_start_kernel+0xf8/0x130
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2010-04-14 16:03 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 1:26 INFO: suspicious rcu_dereference_check() usage - include/linux/cgroup.h:492 invoked rcu_dereference_check() without protection! Miles Lane
2010-03-11 3:28 ` Paul E. McKenney
2010-04-12 18:44 ` Eric Paris
2010-04-12 18:47 ` Peter Zijlstra
2010-04-14 10:47 ` Peter Zijlstra
2010-04-15 15:47 ` Paul E. McKenney
2010-04-19 3:45 ` Lai Jiangshan
2010-04-19 18:26 ` Eric Paris
2010-04-19 23:01 ` Paul E. McKenney
2010-04-20 1:25 ` Eric Paris
2010-04-20 3:04 ` Paul E. McKenney
2010-04-20 7:21 ` Peter Zijlstra
2010-04-20 8:23 ` [PATCH] RCU: don't turn off lockdep when find suspicious rcu_dereference_check() usage Lai Jiangshan
2010-04-20 8:36 ` Peter Zijlstra
2010-04-20 12:31 ` Eric Paris
2010-04-20 13:28 ` Paul E. McKenney
[not found] ` <j2ya44ae5cd1004200545q6be4ec82o18ae99d93e8c29c7@mail.gmail.com>
2010-04-20 13:52 ` Paul E. McKenney
2010-04-20 15:38 ` Miles Lane
2010-04-21 6:04 ` Borislav Petkov
2010-04-21 21:45 ` Paul E. McKenney
2010-04-21 21:35 ` Paul E. McKenney
2010-04-21 21:48 ` Paul E. McKenney
2010-04-21 21:57 ` Eric Dumazet
2010-04-21 22:14 ` Paul E. McKenney
2010-04-21 23:26 ` Eric W. Biederman
2010-04-22 14:56 ` Vivek Goyal
2010-04-22 16:01 ` Paul E. McKenney
2010-04-23 12:50 ` Miles Lane
2010-04-23 19:42 ` Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 01/12] rcu: Fix RCU lockdep splat in set_task_cpu on fork path Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 02/12] rcu: fix RCU lockdep splat on freezer_fork path Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 03/12] rcu: leave lockdep enabled after RCU lockdep splat Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 04/12] NFSv4: Fix the locking in nfs_inode_reclaim_delegation() Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 05/12] NFS: Fix RCU issues in the NFSv4 delegation code Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 06/12] KEYS: Fix an RCU warning Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 07/12] KEYS: Fix an RCU warning in the reading of user keys Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 08/12] cgroup: Fix an RCU warning in cgroup_path() Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 09/12] cgroup: Fix an RCU warning in alloc_css_id() Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 10/12] sched: Fix an RCU warning in print_task() Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 11/12] cgroup: Check task_lock in task_subsys_state() Paul E. McKenney
2010-04-23 19:43 ` [PATCH v2.6.34-rc5 12/12] memcg: css_id() must be called under rcu_read_lock() Paul E. McKenney
2010-04-23 22:59 ` [PATCH] RCU: don't turn off lockdep when find suspicious rcu_dereference_check() usage Miles Lane
2010-04-24 5:35 ` Miles Lane
2010-04-25 2:36 ` Paul E. McKenney
2010-04-25 2:34 ` Paul E. McKenney
2010-04-25 7:45 ` Johannes Berg
2010-04-25 7:49 ` David Miller
2010-04-26 2:07 ` Paul E. McKenney
2010-04-25 15:49 ` Miles Lane
2010-04-25 20:20 ` Miles Lane
2010-04-26 16:09 ` Paul E. McKenney
2010-04-26 18:35 ` Eric W. Biederman
2010-04-27 4:27 ` Paul E. McKenney
2010-04-27 16:22 ` Paul E. McKenney
2010-04-27 16:33 ` Eric Dumazet
2010-04-27 17:58 ` Miles Lane
2010-04-27 23:31 ` Paul E. McKenney
2010-04-27 23:42 ` David Miller
2010-04-27 23:52 ` Paul E. McKenney
[not found] ` <p2ka44ae5cd1004281358n86ce29d2tbece16b2fb974dab@mail.gmail.com>
2010-04-28 21:37 ` Paul E. McKenney
2010-05-01 17:26 ` Miles Lane
2010-05-01 21:55 ` Paul E. McKenney
2010-05-02 2:00 ` Miles Lane
2010-05-02 4:11 ` Paul E. McKenney
2010-04-21 1:05 ` INFO: suspicious rcu_dereference_check() usage - include/linux/cgroup.h:492 invoked rcu_dereference_check() without protection! Li Zefan
2010-04-21 3:14 ` Paul E. McKenney
2010-04-14 16:03 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414160305.GE2516@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.