All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] improve printf behavior on arm/pxa after enabling 64bit support in printf by default.
Date: Wed, 14 Apr 2010 19:38:16 +0200	[thread overview]
Message-ID: <201004141938.16950.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100409214011.EC6DB1E173@gemini.denx.de>

Dne P? 9. dubna 2010 23:40:11 Wolfgang Denk napsal(a):
> Dear Mikhail Kshevetskiy,
> 
> In message <20100329162346.017a43dc@laska.campus-ws.pu.ru> you wrote:
> > commit 4b142febff71eabdb7ddbb125c7b583b24ddc434 (common: delete
> > CONFIG_SYS_64BIT_VSPRINTF and CONFIG_SYS_64BIT_STRTOUL) breaks printf on
> > my arm/pxa270 board. For example, the code
> > 
> > 	int a = 128;
> > 	printf("a= %d\n", a);
> > 
> > will print zero on the console. The problem reproduced on gcc 4.1.1,
> > 4.3.3, 4.4.1 and 4.4.2.
> > 
> > This patch fix printf unless you'll need printing 64-bit values.
> 
> I doubt that your patch addresses the real cause of the problem.
> Did you check if the stack alignment problem discussed here earlier
> has been fixed for your architecture?
> 
> Best regards,
> 
> Wolfgang Denk

Yes, this is a NAK, sorry. The real problem is addressed by "[PATCH] PXA: Align 
stack to 8 bytes". LDRD and STRD need the memory address aligned to 8 bytes.

Besides my patch also fixes the NAND driver, which didn't work as well and 
possibly various other issues.

  reply	other threads:[~2010-04-14 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 12:23 [U-Boot] [PATCH 1/2] improve printf behavior on arm/pxa after enabling 64bit support in printf by default Mikhail Kshevetskiy
2010-04-09 21:40 ` Wolfgang Denk
2010-04-14 17:38   ` Marek Vasut [this message]
     [not found]   ` <j2kb70f2f961004141612te0cff7b5h8c38e9255937f1dc@mail.gmail.com>
2010-04-15  7:44     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004141938.16950.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.