From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Call for help in reviewing patches (!kvm & linux-user)
Date: Thu, 15 Apr 2010 01:32:17 +0200 [thread overview]
Message-ID: <20100414233217.GD17857@hall.aurel32.net> (raw)
Hi all,
My impression is that few persons have interest in linux-user or
non-KVM targets areas, at least from the development point of view.
I personally don't care about linux-user code, though I have tried to
merge patches in this area anyway, as otherwise they are just
bitrotting on the mailing list.
On the other hand there are quite more people at least following the
development in these areas, as when something is broken, you are usually
told that quite quickly.
The result is that most of the patches I am merging have been reviewed
only by me. This is not very good from the quality point of view, more
people reviewing the code, means less risk of breakage. Reviewing
patches also takes a lot of time, and it is very frustrating for me to
spend most of my time on QEMU merging patches, while I would also like
to spend time writing QEMU code instead. Some days when I open my mail
client on the QEMU folder and see a few patch series posted, I just want
to close it asap.
This is therefore a call for help. If you want patches to get merged
more quickly, and with less risk of breakage, don't hesitate to review
patches posted on the mailing list, and send your comments or an
Acked-by:. This really helps when reviewing the patches.
Aurelien
PS: This is not directed to any person, and some persons are already
doing that, but it's just not enough.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next reply other threads:[~2010-04-14 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 23:32 Aurelien Jarno [this message]
2010-04-15 0:08 ` [Qemu-devel] Re: Call for help in reviewing patches (!kvm & linux-user) Paolo Bonzini
2010-04-15 0:19 ` Alexander Graf
2010-04-15 0:28 ` Paolo Bonzini
2010-04-15 8:25 ` [Qemu-devel] " Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414233217.GD17857@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.