From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Charles Bailey <charles@hashpling.org>,
Mark Rada <marada@uwaterloo.ca>,
git@vger.kernel.org
Subject: Re: [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css
Date: Thu, 15 Apr 2010 03:02:47 +0200 [thread overview]
Message-ID: <201004150302.51242.jnareb@gmail.com> (raw)
In-Reply-To: <7veiihmtjw.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> >> -gitweb.cgi: gitweb.perl $(GITWEB_JS) $(GITWEB_CSS)
> >> +gitweb.cgi: gitweb.perl
> > ...
> > That makes gitweb.cgi not depend on gitweb.min.js, not gitweb.min.css.
>
> That is what I inteded to do.
>
> Unless you are including gitweb.cgi (iow, the contents of the generated
> file depends on the _contents_ of gitweb.min.js (or gitweb.js), gitweb.cgi
> does _not_ depend on these files. Of course if you generate gitweb.cgi
> out of gitweb.perl with one setting of GITWEB_JS and then change your
> mind, then you need to regenerate it, but that is not something you can do
> by comparing file timestamp of gitweb.cgi and the file timestamp of
> $(GITWEB_JS) anyway. You would need to imitate something like how
> GIT-BUILD-OPTIONS is used by the primary Makefile.
Right. I agree.
P.S. This is nt the case with git-instaweb, which literally include
gitweb.js or gitweb.min.js...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-04-15 1:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 5:36 [PATCHv5 2/6] Gitweb: add support for minifying gitweb.css Mark Rada
2010-04-01 8:51 ` Jakub Narebski
2010-04-13 20:28 ` Charles Bailey
2010-04-13 22:30 ` Jakub Narebski
2010-04-14 5:40 ` Mark Rada
2010-04-14 17:22 ` Jakub Narebski
2010-04-14 19:17 ` Mark Rada
2010-04-14 20:04 ` Jakub Narebski
2010-04-14 23:58 ` Junio C Hamano
2010-04-15 0:18 ` Charles Bailey
2010-04-15 0:25 ` Jakub Narebski
2010-04-15 0:46 ` Junio C Hamano
2010-04-15 1:02 ` Jakub Narebski [this message]
2010-04-15 1:21 ` Mark Rada
2010-04-15 1:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004150302.51242.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marada@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.