From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2Nmc-0008ON-TU for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:02:58 -0400 Received: from [140.186.70.92] (port=51760 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2Nmb-0008NL-PA for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2NmY-0005Ex-TP for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:02:57 -0400 Received: from mx20.gnu.org ([199.232.41.8]:17477) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2NmW-0005Ei-5Q for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:02:54 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1O2NmV-0007fK-1b for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:02:51 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Date: Thu, 15 Apr 2010 13:04:40 +0100 References: <1271319378-9811-1-git-send-email-amit.shah@redhat.com> In-Reply-To: <1271319378-9811-1-git-send-email-amit.shah@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201004151304.41241.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Gerd Hoffmann > This series lets interested callers ask for an -EAGAIN return from the > chardev backends (only unix and tcp sockets as of now) to implement > their own flow control. As mentioned previously, I think this is a bad idea. The device has no useful way of determining when to transmit the rest of the data. What you really want is an asynchronous transmit API. Paul