Re: Unreliable next_msg_id (was Re: [PATCH 2/2] Added SQLite history plugin)

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

Hi Niko,

> Hi!
> 
> At first look it seems that ofono stores permanently the next_msg_id
> only when the "sms_remove" functions is called, and that's does not
> happen when ofono quits in a not clean way.
> 
> During our tests, users reported bad behaivour of the sqlite history
> plugins and error messages about sqlite constraints violation, after a
> rude power off of the device (battery drained, forced shutdown with
> long press power button, and so on).

So the immediate fix is to set & sync the SMS settings whenever the next_msg_id 
is updated.

> 
> That's becouse ofono on the next start reads an "old" next_msg_id from
> the permanent storage, so when sending/receiving a new message the
> history plugin fails to insert a new row as one with the same msg_id
> was already inserted in the prev session.
> 
> Any suggestion to fix that?

The proper fix is to generate a SHA1 or MD5 hash over the contents, local 
reception/send time, remote reception / send time, destination / originator of 
the message.

> 
> Finally, we'd like to use some "panic" function in ofono, that should
> power down all modems and warn clients when critical conditions
> happen.
> 
> Is that possible?

Send HUP to the daemon?  Or do you want oFono to keep running?

Regards,
-Denis