From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFC PATCH] lis3: Change lis3 driver to one module
Date: Thu, 15 Apr 2010 12:24:32 +0000 [thread overview]
Message-ID: <20100415142432.7c6dd24c@hyperion.delvare> (raw)
In-Reply-To: <1271333702-1729-1-git-send-email-samu.p.onkalo@nokia.com>
On Thu, 15 Apr 2010 15:15:02 +0300, Samu Onkalo wrote:
> If lis3 driver is compiled as module, it consists of two modules:
> core and interface. However, both of them are mandatory for
> proper functionality. Furthermore, it is possible to keep
> /dev/freefall open and remove interface part of the driver.
> Kernel crashes when the /dev/freefall handle is closed.
>
> Makefile is modifed so that now there is
> only one module. Filename for core part is also changed
> from lis3lv02d to lis3lv02d-core.c.
>
> New modules:
> lis3lv02d (for hp-laptops)
> lis3lv02d_i2c for I2C connected boards
> lis3lv02d_spi for SPI connected boards.
This duplicates 11kB of binary code across 3 drivers. And you won't be
able to load more than one of them due to common symbols. So, nack.
There must be a better way to solve this problem.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-04-15 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 12:15 [lm-sensors] [RFC PATCH] lis3: Change lis3 driver to one module Samu Onkalo
2010-04-15 12:24 ` Jean Delvare [this message]
2010-04-16 5:11 ` samu.p.onkalo
2010-04-16 7:37 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415142432.7c6dd24c@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.