Re: Fwd: [PATCH 0/18] Nested Virtualization: Overview

[Christoph Egger <Christoph.Egger@amd.com>]

On Friday 16 April 2010 11:07:08 Qing He wrote:
> On Thu, 2010-04-15 at 21:20 +0800, Christoph Egger wrote:
> > This patch series brings Nested Virtualization to Xen.
> > I have attached two documents Nested_Virtualization.pdf and
> > XenNestedHVM.pdf.
>
> This code is NOT generic and doesn't fit for vmx, although it is placed in
> hvm directory.
>
> For example, the structure v->arch.hvm_vcpu.nestedhvm is filled with
> svm specific registers and concepts, so is the arch/x86/hvm/nestedhvm.c,
> this file even includes vmcb_struct, as well as things like cpuids and
> efer. A vmx adaption to this nestedhvm would be way too difficult if not
> impossible.
>
> These files should go to arch/x86/hvm/svm instead since they are really svm
> specific, so is the struct nestedhvm, v->arch.hvm_svm fits better.

Well, that is what I expected from noone else than Intel :-)

Please read the XenNestedHVM.pdf paper, particularly the section "Software 
Architecture". This describes how this is made to be generic and what needs
to be done to adapt to Intel.

I estimate one or two weeks for you to have NestedHVM on Intel
based on my patchset.


The way you suggest to go makes the xen source tree and the xen binary
a lot larger than necessary.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632