From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] phonesim: Refactor SimApplication api, add a UI.
Date: Fri, 16 Apr 2010 15:06:53 -0500 [thread overview]
Message-ID: <201004161506.54015.denkenz@gmail.com> (raw)
In-Reply-To: <1270795455-7067-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
Hi Andrew,
> Try to move all the AT parsing / generating out of applications, just send
> ready envelopes, terminal responses, commands between the application
> and the SimRules class.
> ---
> src/control.cpp | 35 +++++++++++
> src/control.h | 1 +
> src/controlbase.ui | 71 ++++++++++++++++++++++
> src/hardwaremanipulator.cpp | 42 +++++++++++++
> src/hardwaremanipulator.h | 7 ++
> src/phonesim.cpp | 138
> +++++++++++++++++++++++++++++++++++++++---- src/phonesim.h |
> 6 ++
> src/simapplication.cpp | 137
> ++++++++++++++---------------------------- src/simapplication.h |
> 27 +++++----
> 9 files changed, 349 insertions(+), 115 deletions(-)
This patch has now been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-04-16 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 6:44 [PATCH 2/2] phonesim: Refactor SimApplication api, add a UI Andrzej Zaborowski
2010-04-16 20:06 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004161506.54015.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.