Re: [PATCH 4/8] Add skeleton of src/emulator.c

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

Hi Zhenhua,

> ---
>  Makefile.am        |    7 +-
>  include/dbus.h     |    1 +
>  include/emulator.h |   75 +++++++++++++++++++
>  src/emulator.c     |  203
>  ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/ofono.h        
| 
>    4 +
>  5 files changed, 287 insertions(+), 3 deletions(-)
>  create mode 100644 include/emulator.h
>  create mode 100644 src/emulator.c
> 

I suggest we handle this one a bit differently.  Let us create an Emulator atom 
that has no driver (similar to how MessageWaiting atom works).  Then have each 
interested atom declare an atom watch on the Emulator atom.  When one is 
created, let the atom get notified and register any AT command handlers it 
wishes.  If the atom itself goes away, it needs to de-register at commands 
from all relevant emulators.

Potentially there might be several emulators at once in the system (e.g. one 
for DUN, one for HFP, one for SPP, etc)

Regards,
-Denis