All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 09/12] tabled: drop double prefixing
Date: Sat, 17 Apr 2010 22:42:57 -0600	[thread overview]
Message-ID: <20100417224257.0bd00861@redhat.com> (raw)

On Fedora 14, the following is seen in syslog:

Apr 17 19:58:52 niphredil tabled: tabled: connecting to site
 hitlain.zaitcev.lan:8083: No route to host
Apr 17 19:58:56 niphredil tabled: tabled: DB_ENV->rep_elect:WARNING:
 nvotes (1) is sub-majority with nsites (2)

Drop the extra prefix, it only wastes screen space.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 lib/tdb.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

commit eb60e6e5c97fe316d23b9b21ba020bca924e879e
Author: Master <zaitcev@lembas.zaitcev.lan>
Date:   Sat Apr 17 20:31:56 2010 -0600

    Fix double tagging in syslog.

diff --git a/lib/tdb.c b/lib/tdb.c
index cd65371..12ff231 100644
--- a/lib/tdb.c
+++ b/lib/tdb.c
@@ -38,7 +38,12 @@ enum {
 
 static void db4syslog(const DB_ENV *dbenv, const char *errpfx, const char *msg)
 {
-	syslog(LOG_WARNING, "%s: %s", errpfx, msg);
+	/*
+	 * Since we use syslog, we discard the prefix set in tdb_init,
+	 * because syslog adds our own prefix too. The errpfx would be
+	 * useful if we weren't dumping to syslog here.
+	 */
+	syslog(LOG_WARNING, "%s", msg);
 }
 
 static int buckets_owner_idx(DB *secondary, const DBT *pkey, const DBT *pdata,

             reply	other threads:[~2010-04-18  4:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18  4:42 Pete Zaitcev [this message]
2010-04-19  4:48 ` [Patch 09/12] tabled: drop double prefixing Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100417224257.0bd00861@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.