From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Al Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [infiniband-diags] fix libibnetdisc portguid hashing corner case
Date: Sun, 18 Apr 2010 19:47:34 +0300 [thread overview]
Message-ID: <20100418164734.GM11943@me> (raw)
In-Reply-To: <1271267283.17987.120.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>
On 10:48 Wed 14 Apr , Al Chu wrote:
> Hey Sasha,
>
> This patch fixes a corner case in libibnetdisc that was storing
> portguids w/ a guid of 0.
>
> This bug was relatively innoucuous for ibnetdiscover b/c ibnetdiscover
> does not output these ports. However, it became a problem for me in the
> caching library as I attempted to reconstruct a fabric, and multiple
> ports were identifying themselves with identical guids [1].
>
> Al
>
> [1] - The fact the caching code assumes duplicate guids can't exist is
> also a bug. But that's for another patch. This is a bug by itself.
>
> --
> Albert Chu
> chu11-i2BcT+NCU+M@public.gmane.org
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory
> Date: Tue, 13 Apr 2010 14:01:43 -0700
> From: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> Subject: [PATCH] fix libibnetdisc portguid hashing corner case
> Message-Id: <1271264633.17987.112.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>
> Mime-Version: 1.0
> Content-Transfer-Encoding: 7bit
>
>
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
Applied. Thanks.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-04-18 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 17:48 [infiniband-diags] fix libibnetdisc portguid hashing corner case Al Chu
[not found] ` <1271267283.17987.120.camel-X2zTWyBD0EhliZ7u+bvwcg@public.gmane.org>
2010-04-18 16:47 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100418164734.GM11943@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=chu11-i2BcT+NCU+M@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.