All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [RFC PATCH 2/2] SubmittingPatches: Complete rewrite of section 0
Date: Sun, 18 Apr 2010 19:21:13 -0500	[thread overview]
Message-ID: <20100419002113.GA14202@progeny.tock> (raw)
In-Reply-To: <1271620467-sup-7590@kytes>

Ramkumar Ramachandra wrote:

> This rewrite makes section 0 less verbose and more readable. It is
> intended to be squashed into the previous commit.

Nice.

> +To find the tip of a topic branch, run "git log --first-parent
> +master..pu" and look for the merge commit. The grandparent of this
> +commit is the tip of the topic branch.

The reader is not looking for the second-generation grand-parent foo~2
but the second parent foo^2, using terminology from git-rev-parse.1.

I guess the “second parent” term always involves this potential
confusion.  Luckily, the uninitiated reader can infer from the context
that foo~2 is not the intended commit, so there is no need to resort
to awkward phrases like “the second first-generation parent”.

Jonathan

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 0b62b62..8db22ef 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -79,7 +79,7 @@ change is relevant to.
    rebase your work.
 
 To find the tip of a topic branch, run "git log --first-parent
-master..pu" and look for the merge commit. The grandparent of this
+master..pu" and look for the merge commit. The second parent of this
 commit is the tip of the topic branch.
 
 (1) Make separate commits for logically separate changes.

      reply	other threads:[~2010-04-19  0:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18 19:54 [RFC PATCH 2/2] SubmittingPatches: Complete rewrite of section 0 Ramkumar Ramachandra
2010-04-19  0:21 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419002113.GA14202@progeny.tock \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.