From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [RFC] [PATCH 0/2] Some clean-up to MCA handling Date: Mon, 19 Apr 2010 12:06:52 +0200 Message-ID: <201004191206.53002.Christoph.Egger@amd.com> References: <789F9655DD1B8F43B48D77C5D30659731D797FD1@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731D797FD1@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" Cc: "Frank.Vanderlinden@Sun.COM" , "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Monday 19 April 2010 10:58:44 Jiang, Yunhong wrote: > These two patches includes some clean-up/changes to MCA handling. > > The mce_extended.patch change the method to get the extended MCA > information. This change is somwhat straightforward and is easy to > understand. But please notice it changes some interface in > include/public/arch-x86/xen-mca.h. This breaks backward-compatibility. You can't change the API/ABI just for the sake of "easier" internal handling. Please explain: - what exactly is wrong with the interface as it is in upstream ? - what *requries* an API/ABI change ? Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632