All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	andi@firstfloor.org, alan@lxorguk.ukuu.org.uk, tytso@mit.edu,
	iws@ovro.caltech.edu
Subject: Re: [PATCH 2/4] remove the old non generic API
Date: Mon, 19 Apr 2010 09:15:15 -0700	[thread overview]
Message-ID: <20100419161515.GA17949@suse.de> (raw)
In-Reply-To: <1271691184.12238.2.camel@wall-e.seibold.net>

On Mon, Apr 19, 2010 at 05:33:04PM +0200, Stefani Seibold wrote:
> Am Montag, den 19.04.2010, 08:28 -0700 schrieb Greg KH:
> > On Sun, Apr 18, 2010 at 11:05:16PM +0200, stefani@seibold.net wrote:
> > > From: Stefani Seibold <stefani@seibold.net>
> > > 
> > > This patch simple remove the whole kfifo.c and kfifo.h files. The next
> > > patch will replace it with the new generic kfifo API.
> > 
> > But you just broke the kernel build at this point in the patch sequence,
> > which is not allowed :(
> > 
> 
> I know, but the only way is to merge the patch 2 and 3 together which
> results in a very large and unreadable patch.
> 
> If desired i will do this...

Or you can rename files, or do all sorts of other things instead of
breaking the build, which again, is not allowed, so don't do it :)

thanks,

greg k-h

  reply	other threads:[~2010-04-19 16:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18 21:05 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 21:05 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-04-18 21:05 ` [PATCH 2/4] remove the old non generic API stefani
2010-04-19 15:28   ` Greg KH
2010-04-19 15:33     ` Stefani Seibold
2010-04-19 16:15       ` Greg KH [this message]
2010-04-18 21:05 ` [PATCH 3/4] add the new generic kfifo API stefani
2010-04-18 21:05 ` [PATCH 4/4] add example files to the kernel sample directory stefani
  -- strict thread matches above, loose matches on Subject: below --
2010-04-18 20:54 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-18 20:54 ` [PATCH 2/4] remove the old non generic API stefani
2010-02-12  7:52 [PATCH 0/4] enhanced reimplemention of the kfifo API Stefani Seibold
2010-02-12  7:58 ` [PATCH 2/4] remove the old non generic API Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419161515.GA17949@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andi@firstfloor.org \
    --cc=iws@ovro.caltech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefani@seibold.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.