From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mc13783-regulator: fix a memory leak in mc13783_regulator_remove
Date: Tue, 20 Apr 2010 02:01:00 +0900 [thread overview]
Message-ID: <20100419170059.GB29819@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <h2t427d64721004181858s4c01a195ma70d3ce96ee2d343@mail.gmail.com>
On Mon, Apr 19, 2010 at 09:58:02AM +0800, Axel Lin wrote:
> This patch fixes a memory leak by freeing priv in mc13783_regulator_remove
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but note that...
> + platform_set_drvdata(pdev, NULL);
> +
This is completely unrelated to what your description says (and is not
needed).
next prev parent reply other threads:[~2010-04-19 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 1:58 [PATCH] mc13783-regulator: fix a memory leak in mc13783_regulator_remove Axel Lin
2010-04-19 12:34 ` Liam Girdwood
2010-04-19 17:01 ` Mark Brown [this message]
2010-04-20 5:34 ` Axel Lin
2010-04-20 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419170059.GB29819@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=s.hauer@pengutronix.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.