From: Shahar Havivi <shaharh@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Return contorl to host on usb_del monitor command
Date: Mon, 19 Apr 2010 21:55:58 +0300 [thread overview]
Message-ID: <20100419185555.GA3914@redhat.com> (raw)
When removing usb on guest via usb_del monitor command, qemu does
not return the control to the host, the only solution user have is to
unplug/plug the device again in order to get the device back to the host
Signed-off-by: Shahar Havivi <shaharh@redhat.com>
---
hw/usb-bus.c | 4 ++++
hw/usb.h | 1 +
usb-linux.c | 11 +++++++++++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index ee0e9e3..9781ac6 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -208,6 +208,10 @@ int usb_device_delete_addr(int busnr, int addr)
return -1;
dev = port->dev;
+ if (!strcmp(dev->info->usbdevice_name, "host")) {
+ usb_host_device_release(dev);
+ }
+
qdev_free(&dev->qdev);
return 0;
}
diff --git a/hw/usb.h b/hw/usb.h
index 00d2802..f6f7cc4 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -258,6 +258,7 @@ void usb_send_msg(USBDevice *dev, int msg);
USBDevice *usb_host_device_open(const char *devname);
int usb_host_device_close(const char *devname);
void usb_host_info(Monitor *mon);
+int usb_host_device_release(USBDevice *dev);
/* usb-hid.c */
void usb_hid_datain_cb(USBDevice *dev, void *opaque, void (*datain)(void *));
diff --git a/usb-linux.c b/usb-linux.c
index d0d7cff..9db94dd 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -284,6 +284,17 @@ static void async_cancel(USBPacket *unused, void *opaque)
}
}
+/* release usb device, return control to host */
+int usb_host_device_release(USBDevice *dev)
+{
+ int ret;
+
+ USBHostDevice *s = DO_UPCAST(USBHostDevice, dev, dev);
+ ret = ioctl(s->fd, USBDEVFS_RESET);
+
+ return ret;
+}
+
static int usb_host_claim_interfaces(USBHostDevice *dev, int configuration)
{
int dev_descr_len, config_descr_len;
--
1.6.3.3
next reply other threads:[~2010-04-19 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 18:55 Shahar Havivi [this message]
2010-05-18 18:26 ` [Qemu-devel] [PATCH] Return contorl to host on usb_del monitor command Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419185555.GA3914@redhat.com \
--to=shaharh@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.