Re: [PATCH 2/5] arm: msm: smd: use either package v3 or v4 not both

[Pavel Machek <pavel@ucw.cz>]

On Mon 2010-04-19 11:03:06, Daniel Walker wrote:
> From: Daniel Walker <c_dwalke@quicinc.com>
> 
> This modifies SMD to use either the package v3 or package v4,
> but not both. The current code tries to allocate as v4 on all
> system which can produce a scary looking error message on boot up,
> 
> smem_find(16, 40): wrong size 16424
> smd_alloc_channel() cid=02 size=08192 'SMD_RPCCALL'
> 
> With this error the code then falls back on the package v3 allocation
> method. This method is inefficient because it causes a slow down
> on some systems even when the allocation method can be determined
> at compile time. It also causes a kernel size increase that effects
> all system and is not needed.

Well... it adds about 100 bytes to kernel text and produces
unmeasurable slowdown.

> --- a/arch/arm/mach-msm/Kconfig
> +++ b/arch/arm/mach-msm/Kconfig
> @@ -7,6 +7,7 @@ choice
>  config ARCH_MSM7X00A
>  	bool "MSM7x00A / MSM7x01A"
>  	select ARCH_MSM_ARM11
> +	select MSM_SMD_PKG3
>  	select CPU_V6
>  
>  config ARCH_QSD8X50
> @@ -325,6 +326,9 @@ config MSM_SERIAL_DEBUGGER_CONSOLE
>  	  Enables a console so that printk messages are displayed on
>  	  the debugger serial port as the occur.
>  
> +config MSM_SMD_PKG3
> +	bool
> +

...but I guess that as long as kconfig system gets it right
automatically... its probably ok.

....well, will that prevent us from producing 'generic' kernel in
future?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html