All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikanth Karthikesan <knikanth@suse.de>
To: Alasdair G Kergon <agk@redhat.com>,
	device-mapper development <dm-devel@redhat.com>,
	Stefan Assmann <s.assmann@gmx.de>
Subject: [PATCH] Just inform and dont warn when DM_DEV_REMOVE is tried on a open device
Date: Tue, 20 Apr 2010 12:46:58 +0530	[thread overview]
Message-ID: <201004201246.58828.knikanth@suse.de> (raw)

Dont warn when DM_DEV_REMOVE ioctl is tried on a open device.

On openSUSE when cryptsetup and udev interact, cryptsetup sometimes tries to
remove a dm device currently opened by blkid, which is not a serious issue to
print a kernel warning. The application should retry if -EBUSY is returned. So
let us make it an informational message instead.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>

---

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index d7500e1..dcfa48a 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -729,7 +729,7 @@ static int dev_remove(struct dm_ioctl *param, size_t param_size)
 	 */
 	r = dm_lock_for_deletion(md);
 	if (r) {
-		DMWARN("unable to remove open device %s", hc->name);
+		DMINFO("unable to remove open device %s", hc->name);
 		up_write(&_hash_lock);
 		dm_put(md);
 		return r;

             reply	other threads:[~2010-04-20  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20  7:16 Nikanth Karthikesan [this message]
2010-04-20  8:00 ` [PATCH] Just inform and dont warn when DM_DEV_REMOVE is tried on a open device Milan Broz
2010-04-20  8:43   ` Nikanth Karthikesan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004201246.58828.knikanth@suse.de \
    --to=knikanth@suse.de \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=s.assmann@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.