From: Jens Axboe <jens.axboe@oracle.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [patch] blktrace: disable kill option - take 2
Date: Tue, 20 Apr 2010 13:41:29 +0000 [thread overview]
Message-ID: <20100420134129.GO27497@kernel.dk> (raw)
In-Reply-To: <4BCDABCD.4050800@redhat.com>
On Tue, Apr 20 2010, Edward Shishkin wrote:
>
> Fixup for 513950.
>
> Problem:
> 'blktrace -d <device> -k' does not kill a running
> backgound trace. Executing 'blktrace -d <device> -k'
> for the second time results in "BLKTRACETEARDOWN:
> Invalid argument" message and then each run of
> blktrace on that machine prints the following output:
> BLKTRACESETUP: No such file or directory.
>
> The bug:
> The option -k results in clobbering information
> about running trace by kernel (blk_trace_remove),
> while resources (files open in debugfs by the running
> background blktrace) are not released.
>
> Solution:
> Update documentation:
> Undocument the non-working "kill" option. Advise
> to send SIGINT signall via kill(1) to the running
> background blktrace for its correct termination.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2010-04-20 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 13:27 [patch] blktrace: disable kill option - take 2 Edward Shishkin
2010-04-20 13:41 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420134129.GO27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-btrace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.