All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: ltt-dev@lists.casi.polymtl.ca, linux-mips@linux-mips.org
Subject: Re: [ltt-dev] [PATCH 1/3] lttng: MIPS: Fix syscall entry tracing.
Date: Tue, 20 Apr 2010 09:55:48 -0400	[thread overview]
Message-ID: <20100420135548.GA25175@Krystal> (raw)
In-Reply-To: <1271722791-27885-2-git-send-email-ddaney@caviumnetworks.com>

* David Daney (ddaney@caviumnetworks.com) wrote:
> For the 32-bit kernel and all three ABIs of the 64-bit kernel, we need
> to test the _TIF_KERNEL_TRACE flag on syscall entry.  Otherwise, no
> syscall entry tracing for you!

Merged into the LTTng tree, thanks !

Mathieu

> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
>  arch/mips/kernel/scall32-o32.S |    2 +-
>  arch/mips/kernel/scall64-64.S  |    2 +-
>  arch/mips/kernel/scall64-n32.S |    2 +-
>  arch/mips/kernel/scall64-o32.S |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
> index fd2a9bb..28f262d 100644
> --- a/arch/mips/kernel/scall32-o32.S
> +++ b/arch/mips/kernel/scall32-o32.S
> @@ -52,7 +52,7 @@ NESTED(handle_sys, PT_SIZE, sp)
>  
>  stack_done:
>  	lw	t0, TI_FLAGS($28)	# syscall tracing enabled?
> -	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>  	and	t0, t1
>  	bnez	t0, syscall_trace_entry	# -> yes
>  
> diff --git a/arch/mips/kernel/scall64-64.S b/arch/mips/kernel/scall64-64.S
> index 18bf7f3..38c0c95 100644
> --- a/arch/mips/kernel/scall64-64.S
> +++ b/arch/mips/kernel/scall64-64.S
> @@ -54,7 +54,7 @@ NESTED(handle_sys64, PT_SIZE, sp)
>  
>  	sd	a3, PT_R26(sp)		# save a3 for syscall restarting
>  
> -	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>  	LONG_L	t0, TI_FLAGS($28)	# syscall tracing enabled?
>  	and	t0, t1, t0
>  	bnez	t0, syscall_trace_entry
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index 3541fd3..fbecc01 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -53,7 +53,7 @@ NESTED(handle_sysn32, PT_SIZE, sp)
>  
>  	sd	a3, PT_R26(sp)		# save a3 for syscall restarting
>  
> -	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>  	LONG_L	t0, TI_FLAGS($28)	# syscall tracing enabled?
>  	and	t0, t1, t0
>  	bnez	t0, n32_syscall_trace_entry
> diff --git a/arch/mips/kernel/scall64-o32.S b/arch/mips/kernel/scall64-o32.S
> index 14dde4c..0db5589 100644
> --- a/arch/mips/kernel/scall64-o32.S
> +++ b/arch/mips/kernel/scall64-o32.S
> @@ -81,7 +81,7 @@ NESTED(handle_sys, PT_SIZE, sp)
>  	PTR	4b, bad_stack
>  	.previous
>  
> -	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +	li	t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>  	LONG_L	t0, TI_FLAGS($28)	# syscall tracing enabled?
>  	and	t0, t1, t0
>  	bnez	t0, trace_a_syscall
> -- 
> 1.6.6.1
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev@lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com

  reply	other threads:[~2010-04-20 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20  0:19 [PATCH 0/3] LTTng patches for MIPS CPUs David Daney
2010-04-20  0:19 ` [PATCH 1/3] lttng: MIPS: Fix syscall entry tracing David Daney
2010-04-20 13:55   ` Mathieu Desnoyers [this message]
2010-04-20  0:19 ` [PATCH 2/3] lttng: MIPS: Dump MIPS system call tables David Daney
2010-04-20 13:56   ` [ltt-dev] " Mathieu Desnoyers
2010-04-20  0:19 ` [PATCH 3/3] lttng: MIPS: Use 64 bit counter for trace clock on Octeon CPUs David Daney
2010-04-20 13:56   ` [ltt-dev] " Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100420135548.GA25175@Krystal \
    --to=compudj@krystal.dyndns.org \
    --cc=ddaney@caviumnetworks.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.