From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: Current shared snapshots
Date: Tue, 20 Apr 2010 11:03:40 -0400 [thread overview]
Message-ID: <20100420150340.GD7538@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1004200309030.24170@hs20-bc2-1.build.redhat.com>
On Tue, Apr 20 2010 at 3:15am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Hi
>
> I uploaded current shared snapshots at
> http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r19/
>
> Changes: cache shrinking over time, removed unused code, documentation
> changes from you.
>
> It doesn't contain variable renaming patches that you sent me, I think
> it's not needed and also --- renaming variables with regular expressions
> is dangerous. It may patch something that wasn't intended to be patched.
That is unfortunate. I guess I won't waste my time on such cleanups in
the future. Seriously, dismissing those changes as "not needed" is
frustrating. Those changes really do serve to add consistency.
Your concern about using regex to do renames is valid but hardly reason
to dismiss changes. Any unwanted change is easily caught by compiling
the result.
I really do hope you'll reconsider taking those rename changes. I'll
refresh and re-review the changes against r19 if you're willing to
reconsider.
Mike
next prev parent reply other threads:[~2010-04-20 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 7:15 Current shared snapshots Mikulas Patocka
2010-04-20 15:03 ` Mike Snitzer [this message]
2010-04-22 21:01 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420150340.GD7538@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.