From: Greg KH <gregkh@suse.de>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
andi@firstfloor.org, alan@lxorguk.ukuu.org.uk, tytso@mit.edu,
iws@ovro.caltech.edu
Subject: Re: [PATCH 0/4] enhanced reimplemention of the kfifo API
Date: Tue, 20 Apr 2010 15:13:18 -0700 [thread overview]
Message-ID: <20100420221318.GA2411@suse.de> (raw)
In-Reply-To: <1271795747.16051.18.camel@wall-e.seibold.net>
On Tue, Apr 20, 2010 at 10:35:47PM +0200, Stefani Seibold wrote:
> >
> > > This are the features which are currently not used in the kernel:
> > >
> > > kfifo_to_user()
> > > kfifo_from_user()
> > > kfifo_dma_....() macros
> > > kfifo_esize()
> > > kfifo_recsize()
> > > kfifo_put()
> > > kfifo_get()
> > > the fixed size record elements, exclude "unsigned char" fifo's and
> > > the variable size records fifo's
> >
> > If you have features that have no users, why add them? Do you think
> > that some drivers need/want these features?
> >
>
> Some developers ask me for this features, so i am a nice girl and
> implemented it. Especially the kfifo_to_user() and kfifo_from_user() was
> desired and is IMHO very useful.
>
> kfifo_put(), kfifo_get(), kfifo_esize() and kfifo_recsize() didn't coast
> anything, because there are only macros.
>
> Andrew agreed that we add this for a given time period, and have a look
> what happens. The code overhead is not to much.
>
> It is a chicken and egg problem: If we do not provide this features,
> nobody can use it and everyone will write it's own implementation.
Ok, fair enough.
thanks,
greg k-h
next prev parent reply other threads:[~2010-04-20 22:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 20:06 [PATCH 0/4] enhanced reimplemention of the kfifo API stefani
2010-04-20 20:06 ` [PATCH 1/4] fix kfifo miss use of nozami.c stefani
2010-04-20 20:06 ` [PATCH 2/4] add the new generic kfifo API stefani
2010-04-20 20:06 ` [PATCH 3/4] replace the old non generic API stefani
2010-04-20 20:06 ` [PATCH 4/4] add example files to the kernel sample directory stefani
2010-04-20 20:16 ` [PATCH 0/4] enhanced reimplemention of the kfifo API Greg KH
2010-04-20 20:35 ` Stefani Seibold
2010-04-20 22:13 ` Greg KH [this message]
2010-04-20 20:42 ` Ira W. Snyder
2010-04-20 22:14 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 6:40 stefani
2010-07-20 13:05 stefani
2010-04-18 21:05 stefani
2010-04-18 20:54 stefani
2010-02-12 7:52 Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420221318.GA2411@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.