From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH][usercr] Add numeric hdr.type to ckptinfo
Date: Tue, 20 Apr 2010 19:23:14 -0700 [thread overview]
Message-ID: <20100421022314.GA25133@us.ibm.com> (raw)
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Tue, 20 Apr 2010 19:08:08 -0700
Subject: [PATCH 1/1] Add the numeric value of hdr.type
Debug messaages into dmesg rightly print only the numeric value of the
CKPT_HDR type. ckptinfo prints the descriptive macro. But to correlate
the two, one has to dive into the source to find the record type say 302
in dmesg and then find CKPT_HDR_FILE_DESC in ckptinfo output. Would be
easier if ckptinfo printed both the numeric value and descriptive macro.
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
ckptinfo.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ckptinfo.c b/ckptinfo.c
index 6190301..09b9db4 100644
--- a/ckptinfo.c
+++ b/ckptinfo.c
@@ -182,8 +182,8 @@ static int image_read_obj(int fd, struct ckpt_hdr **hh)
if (ret == 0)
return 0;
- VERBOSE("info: [@%lu] object %s len %d\n",
- __filepos, hdr_to_str(h.type), h.len);
+ VERBOSE("info: [@%lu] object %3d %s len %d\n",
+ __filepos, h.type, hdr_to_str(h.type), h.len);
p = malloc(h.len);
if (!p) {
--
1.6.6.1
next reply other threads:[~2010-04-21 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 2:23 Sukadev Bhattiprolu [this message]
[not found] ` <20100421022314.GA25133-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-04-21 2:18 ` [PATCH][usercr] Add numeric hdr.type to ckptinfo Serge E. Hallyn
2010-04-25 20:25 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421022314.GA25133@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.