All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: fabien.chouteau@gmail.com
Cc: linux-usb@vger.kernel.org,
	Fabien Chouteau <fabien.chouteau@barco.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Michal Nazarewicz <m.nazarewicz@samsung.com>,
	Roel Kluin <roel.kluin@gmail.com>,
	Randy Dunlap <randy.dunlap@oracle.com>, Tejun Heo <tj@kernel.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Composite framework: Add suspended sysfs entry
Date: Wed, 21 Apr 2010 11:05:52 -0700	[thread overview]
Message-ID: <20100421180552.GB24842@suse.de> (raw)
In-Reply-To: <1271864304-4279-1-git-send-email-fabien.chouteau@gmail.com>

On Wed, Apr 21, 2010 at 05:38:21PM +0200, fabien.chouteau@gmail.com wrote:
> From: Fabien Chouteau <fabien.chouteau@barco.com>
> 
> 
> Signed-off-by: Fabien Chouteau <fabien.chouteau@barco.com>
> ---
>  drivers/usb/gadget/composite.c |   21 +++++++++++++++++++++
>  include/linux/usb/composite.h  |    1 +
>  include/linux/usb/gadget.h     |    4 ++++
>  3 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 09289bb..a5352f3 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -898,6 +898,18 @@ static void composite_disconnect(struct usb_gadget *gadget)
>  
>  /*-------------------------------------------------------------------------*/
>  
> +static ssize_t composite_show_suspended(struct device *dev,
> +					struct device_attribute *attr,
> +					char *buf)

As you added a sysfs file, it is required that you also add an entry in
Documentation/ABI/ that describes the file and what it is for.  Please
respin this with that added to the patch.

thanks,

greg k-h

  parent reply	other threads:[~2010-04-21 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 15:38 [PATCH 1/2] Composite framework: Add suspended sysfs entry fabien.chouteau
2010-04-21 15:38 ` [PATCH 2/2] Mass storage gadget: Handle eject request fabien.chouteau
2010-04-21 16:43   ` Michał Nazarewicz
2010-04-21 18:05     ` Greg KH
2010-04-21 18:05 ` Greg KH [this message]
2010-04-22 13:01   ` [PATCH 1/2] Composite framework: Add suspended sysfs entry Chouteau Fabien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421180552.GB24842@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=fabien.chouteau@barco.com \
    --cc=fabien.chouteau@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.nazarewicz@samsung.com \
    --cc=randy.dunlap@oracle.com \
    --cc=roel.kluin@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.