Re: [PATCH] ppp: change MTU on TUN device when MRU option received

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Kristen,

> ---
>  gatchat/ppp_net.c |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/gatchat/ppp_net.c b/gatchat/ppp_net.c
> index c1f2eb4..fc1f9fb 100644
> --- a/gatchat/ppp_net.c
> +++ b/gatchat/ppp_net.c
> @@ -50,10 +50,26 @@ struct ppp_net {
> 
>  void ppp_net_set_mtu(struct ppp_net *net, guint16 mtu)
>  {
> +	struct ifreq ifr;
> +	int sock;
> +
>  	if (net == NULL)
>  		return;
> 
>  	net->mtu = mtu;
> +
> +	sock = socket(AF_INET, SOCK_DGRAM, 0);
> +	if (sock < 0)
> +		return;
> +

I think it would be a good idea to make this function return a gboolean 
indicating success or failure instead of silently returning.

> +	memset(&ifr, 0, sizeof(ifr));
> +
> +	strncpy(ifr.ifr_name, net->if_name, sizeof(ifr.ifr_name));
> +	ifr.ifr_mtu = mtu;
> +	if (ioctl(sock, SIOCSIFMTU, (caddr_t) &ifr) < 0)
> +		g_printerr("Unable to change MTU\n");

Generally the preferred style is to not have a space after memset but do have 
space before the if.

> +
> +	close(sock);
>  }
> 
>  void ppp_net_process_packet(struct ppp_net *net, guint8 *packet)
> 

Otherwise patch looks good.

Regards,
-Denis