From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 23 Apr 2010 10:55:52 -0400 Subject: [U-Boot] [PATCH] mmc: new legacy MMC/SPI driver In-Reply-To: <20100423082034.GM20047@leila.ping.de> References: <1271913394-12958-1-git-send-email-thomas@wytron.com.tw> <1271993307-10361-1-git-send-email-vapier@gentoo.org> <20100423082034.GM20047@leila.ping.de> Message-ID: <201004231055.53176.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 23 April 2010 04:20:34 Wolfgang Wegner wrote: > On Thu, Apr 22, 2010 at 11:28:27PM -0400, Mike Frysinger wrote: > > +static short mmc_spi_init_card(struct mmc_spi_dev *pdev) > > +{ > > + unsigned short cntr = 0; > > + > > + /* for making init process beeing silent */ > > + init_mode = 1; > > + /* save length of log for external usage */ > > + pdev->log_len = LOG_LEN; > > + > > + /* 10 bytes(80 cycles) with CS de-asserted */ > > + mmc_spi_dummy_clocks(pdev, 10); > > + pdev->doassert(); > > + if (send_cmd_and_wait(pdev, GO_IDLE_STATE, 0, R1_IDLE_STATE, > > MMC_INIT_TIMEOUT)) + return 1; > > + pdev->deassert(); > > + /* Send One Byte Delay */ > > + if (pdev->write(Null_Word, 1, pdev->priv_data) < 0) > > + return 1; > > + pdev->doassert(); > > [...] > > Is there any reason to use doassert() and deassert() except to generate > the "dummy" cycles needed to initialize the card? Which driver does > _need_ an explicit cs_activate() and cs_deactivate() outside the > write() and read() functions? i have no idea. i didnt write the driver. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100423/117039a5/attachment.pgp