All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix: transaction id usage in gisi/server.c
Date: Fri, 23 Apr 2010 12:43:41 -0500	[thread overview]
Message-ID: <201004231243.41642.denkenz@gmail.com> (raw)
In-Reply-To: <1272035836-27549-1-git-send-email-Pekka.Pessi@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi Pekka,

> ---
>  gisi/server.c |  111
>  +++++++++++++++++++++++++++----------------------------- 1 files changed,
>  54 insertions(+), 57 deletions(-)

WARNING: space prohibited between function name and open parenthesis '('
#95: FILE: gisi/server.c:88:
+	memset (self, 0, sizeof(*self));

I was nice and fixed it for you this time.  Please get into a habit of checking 
your patches with checkpatch.

Patch has been applied, thanks.

Regards,
-Denis

  parent reply	other threads:[~2010-04-23 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 15:17 [PATCH] Fix: transaction id usage in gisi/server.c Pekka Pessi
2010-04-23 15:27 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-04-23 17:43 ` Denis Kenzior [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-04-23 15:15 =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-04-22 11:26 Pekka Pessi
2010-04-22 21:27 ` Denis Kenzior
2010-04-22 21:32   ` Denis Kenzior
2010-04-23 13:07   ` Pekka Pessi
2010-04-23 13:46     ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-04-23 14:34       ` Marcel Holtmann
2010-04-23 14:57       ` Pekka Pessi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004231243.41642.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.