From: Greg KH <gregkh@suse.de>
To: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add usb_add_bus() function for usb bus list
Date: Fri, 23 Apr 2010 08:03:55 -0700 [thread overview]
Message-ID: <20100423150355.GA7648@suse.de> (raw)
In-Reply-To: <4BD13409.5040003@jp.fujitsu.com>
On Fri, Apr 23, 2010 at 02:45:45PM +0900, Tomohiro Kusumi wrote:
> Hi,
>
> This patch makes usbcore driver sort usb bus on the usb_bus_list by busnum when
> registering a new bus instance.
No one should care about this.
> In current implementation a new bus instance is simply added in front of existing busses.
> Although there is nothing wrong with it in kernel code, reloading HCD may break bus order
> of /proc/bus/usb/devices as it makes usbcore re-register the bus to the list as shown in
> the example below. and it doesn't look good or it may confuse some users.
How does it confuse anyone? (also note that /proc/bus/usb/devices is
not used in modern distros, it's in a different location now.)
Why not fix your tools to report things in the correct order if you
really care about it? The bus number means nothing except a unique id,
it does not matter if things are sorted or not in the debug file.
Actually, in the lsusb-rewrite I am doing, the userspace tool does the
sorting, no need to change the kernel.
So, sorry, I'm not going to accept this change.
greg k-h
prev parent reply other threads:[~2010-04-23 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 5:45 [PATCH] add usb_add_bus() function for usb bus list Tomohiro Kusumi
2010-04-23 15:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423150355.GA7648@suse.de \
--to=gregkh@suse.de \
--cc=kusumi.tomohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.