All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Eric Lescouet <Eric.Lescouet@VirtualLogix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers
Date: Fri, 23 Apr 2010 08:07:34 -0700	[thread overview]
Message-ID: <20100423150734.GA7778@kroah.com> (raw)
In-Reply-To: <4BD179FB.3010309@VirtualLogix.com>

On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote:
> Hi,
>
> The USBIP modules (and some others) have a direct dependency on the following headers:
> - drivers/usb/core/hdc.h (struct usb_hcd and various routines)
> - drivers/usb/core/hub.h (couple of constants)
> Because those headers are not part of include/, it makes it quite difficult
> to compile them as standalone modules (e.g.: against pre-compiled kernel).

Then don't do that :)

> hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/.
>
> What do you think?

I think the code needs to be cleaned up and merged to the main part of
the kernel tree, then this wouldn't be an issue, right?

Also, please cc: the linux-usb@vger.kernel.org list for USB related
things in the future.

thanks,

greg k-h

  reply	other threads:[~2010-04-23 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 10:44 USBIP (staging) driver's dependency on drivers/usb/core internal headers Eric Lescouet
2010-04-23 15:07 ` Greg KH [this message]
2010-04-23 15:52   ` Alan Stern
2010-04-23 16:14     ` Greg KH
2010-04-23 16:31       ` Eric Lescouet
2010-04-23 16:37         ` Greg KH
2010-04-23 16:50         ` Alan Stern
2010-04-23 17:51           ` Eric Lescouet
2010-04-23 18:04             ` Alan Stern
2010-04-24  1:24               ` Eric Lescouet
2010-04-24 15:17                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100423150734.GA7778@kroah.com \
    --to=greg@kroah.com \
    --cc=Eric.Lescouet@VirtualLogix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.