All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 2/3] ad193x: fix wrong register setting in ad193x_set_dai_fmt
Date: Fri, 23 Apr 2010 16:14:27 +0100	[thread overview]
Message-ID: <20100423151427.GD27232@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1271842609-18276-3-git-send-email-21cnbao@gmail.com>

On Wed, Apr 21, 2010 at 05:36:48PM +0800, Barry Song wrote:
> Signed-off-by: Barry Song <21cnbao@gmail.com>

Please provide more detailed changelogs.  What is wrong with the
register settings?  I've applied the patch for 2.6.35 since it doesn't
apply on 2.6.34 but it'd have been very much more helpful if you'd said
what the problem you were trying to fix is.

  parent reply	other threads:[~2010-04-23 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21  9:36 [PATCH 0/3] ad193x set_pll, fix register setting and typo Barry Song
2010-04-21  9:36 ` [PATCH 1/3] ad193x: add set_pll entry to support different clock input Barry Song
2010-04-21  9:36   ` [PATCH 2/3] ad193x: fix wrong register setting in ad193x_set_dai_fmt Barry Song
2010-04-21  9:36     ` [PATCH 3/3] ad193x: fix typo, delete redundant space Barry Song
2010-04-23 15:15       ` Mark Brown
2010-04-23 15:14     ` Mark Brown [this message]
2010-04-24 17:12       ` [PATCH 2/3] ad193x: fix wrong register setting in ad193x_set_dai_fmt Barry Song
2010-04-23 15:06   ` [PATCH 1/3] ad193x: add set_pll entry to support different clock input Mark Brown
2010-04-27 10:12     ` Barry Song
2010-04-21 10:05 ` [PATCH 0/3] ad193x set_pll, fix register setting and typo Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100423151427.GD27232@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=21cnbao@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.