From: Wolfram Sang <w.sang@pengutronix.de>
To: Guillaume LECERF <glecerf@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Chris Moore <moore@free.fr>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v4 1/2] [MTD] remove bogus warning about missing boot bank location
Date: Sat, 24 Apr 2010 11:35:35 +0200 [thread overview]
Message-ID: <20100424093535.GA7199@pengutronix.de> (raw)
In-Reply-To: <20100423133347.27001.99171.stgit@shiryu.yomgui.biz>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Fri, Apr 23, 2010 at 03:33:47PM +0200, Guillaume LECERF wrote:
> From: Uwe Kleine-König <Uwe.Kleine-Koenigi@digi.com>
>
> After the deleted block bootloc is only used once as follows:
>
> if (bootloc == 3 && something_else) {
> ...
>
> So setting bootloc = 2 doesn't change anything. Taking that the warning is
> wrong and missleading.
>
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
I think you need to sign it off as well (as you are sending it upstream).
And although I am not the one picking the patches up, I could imagine it helps
David if you respin the whole patch-series with all the latest updates and
adding all the Acked-by and Reviewed-by tags you got. This should speed things
up and help merging.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-04-24 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 13:33 [PATCH v4 1/2] [MTD] remove bogus warning about missing boot bank location Guillaume LECERF
2010-04-23 13:33 ` [PATCH v4 2/2] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional Guillaume LECERF
2010-04-24 5:13 ` [PATCH v4 1/2] [MTD] remove bogus warning about missing boot bank location Chris Moore
2010-04-24 9:35 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100424093535.GA7199@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=glecerf@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=moore@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.