From: Flavio Leitner <fbl@sysclose.org>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] TCP: avoid to send keepalive probes if it is receiving data
Date: Sun, 25 Apr 2010 20:55:49 -0300 [thread overview]
Message-ID: <20100425235549.GB2550@sysclose.org> (raw)
In-Reply-To: <20100421.224205.18551946.davem@davemloft.net>
On Wed, Apr 21, 2010 at 10:42:05PM -0700, David Miller wrote:
> From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Sun, 18 Apr 2010 23:34:15 +0300 (EEST)
>
> > I fail to see why the addition of this new variable is necessary at all,
> > could either of you enlight me why exactly it's necessary and rcv_tstamp
> > will not suffice?
>
> I agree, the existing rcv_tstamp should serve this purpose just
> fine.
I thought it would break TCP_INFO/tcp_get_info(). Actually, reviewing
the code again I found another variable which does exactly what is needed.
I'll post a new patch for review.
thanks,
--
Flavio
next prev parent reply other threads:[~2010-04-25 23:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 15:06 TCP keepalive question Flavio Leitner
2010-04-17 17:28 ` [PATCH] TCP: avoid to send keepalive probes if it is receiving data Flavio Leitner
2010-04-18 9:06 ` Eric Dumazet
2010-04-18 14:55 ` [PATCH v2] " Flavio Leitner
2010-04-18 17:15 ` Eric Dumazet
2010-04-18 20:34 ` Ilpo Järvinen
2010-04-22 5:42 ` David Miller
2010-04-25 23:55 ` Flavio Leitner [this message]
2010-04-26 2:40 ` [PATCH v3] TCP: avoid to send keepalive probes if " Flavio Leitner
2010-04-26 9:47 ` Ilpo Järvinen
2010-04-26 18:24 ` David Miller
2010-04-27 4:33 ` [PATCH v4] " Flavio Leitner
2010-04-27 5:06 ` Eric Dumazet
2010-04-27 6:08 ` Ilpo Järvinen
2010-04-27 19:55 ` David Miller
2010-04-25 23:44 ` [PATCH v2] TCP: avoid to send keepalive probes if it is " Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425235549.GB2550@sysclose.org \
--to=fbl@sysclose.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.