From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Ryan Mallon <ryan@bluewatersys.com>
Cc: Mike Rapoport <mike@compulab.co.il>,
linux-kernel@vger.kernel.org,
Yulia Vilensky <vilensky@compulab.co.il>
Subject: Re: [PATCH] ds2782_battery: add support for ds2786 battery gas gauge
Date: Mon, 26 Apr 2010 14:09:01 +0400 [thread overview]
Message-ID: <20100426100901.GA2092@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4BD4A9B4.1010200@bluewatersys.com>
On Mon, Apr 26, 2010 at 08:44:36AM +1200, Ryan Mallon wrote:
[...]
> >>> config BATTERY_DS2782
> >>> - tristate "DS2782 standalone gas-gauge"
> >>> + tristate "DS2782/DS2786 standalone gas-gauge"
> >>> depends on I2C
> >>> help
> >>> - Say Y here to enable support for the DS2782 standalone battery
> >>> + Say Y here to enable support for the DS2782/DS2786 standalone
> >>> battery
> >>
> >> I have only used the DS2782 chip. Can we just change this to DS278x? May
> >> as well change to CONFIG_BATTERY_DS278x while we are here.
> >>
> >
> > Shall we move ds2782_battery.c to ds278x_battery.c at the same time?
> > Changing Kconfig invites the .c file move as well :)
>
> Yes. Are there other gas-gauges in the same family?
Please don't, this is an unneeded churn. I'd won't bother with
renaming Kconfig symbol as well (and btw, that renaming will
break oldconfig, so I strongly suggest not to do it).
So, your current approch of changing the description and help
text is OK.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2010-04-26 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 6:52 [PATCH] ds2782_battery: add support for ds2786 battery gas gauge Mike Rapoport
2010-04-22 7:14 ` Anton Vorontsov
2010-04-22 7:35 ` Mike Rapoport
2010-04-22 21:24 ` Ryan Mallon
2010-04-25 15:33 ` Mike Rapoport
2010-04-25 20:44 ` Ryan Mallon
2010-04-26 10:09 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426100901.GA2092@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=ryan@bluewatersys.com \
--cc=vilensky@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.