From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/6] stkutil: Move advance of ctlv to decicated proactive commands parser
Date: Mon, 26 Apr 2010 10:39:20 -0500 [thread overview]
Message-ID: <201004261039.20895.denkenz@gmail.com> (raw)
In-Reply-To: <i2nfb249edb1004260753u2ddb4067g6f136c918f9bec09@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
Hi Andrew,
> Hi Yang,
>
> On 26 April 2010 12:29, Yang Gu <yang.gu@intel.com> wrote:
> > Not all the proactive commands have comprehension tlv other than command
> > details and device identities. So the appropriate code should be moved to
> > decicated parser if needed.
>
> Maybe parse_dataobj() would be a better place?
Agreed, lets not repeat this in every single command parser.
Regards,
-Denis
next prev parent reply other threads:[~2010-04-26 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 10:29 [PATCH 1/6] stkutil: Fix the assignment to minimum set Yang Gu
2010-04-26 10:29 ` [PATCH 2/6] stkutil: Move advance of ctlv to decicated proactive commands parser Yang Gu
2010-04-26 14:53 ` Andrzej Zaborowski
2010-04-26 15:39 ` Denis Kenzior [this message]
2010-04-27 9:42 ` Gu, Yang
2010-04-26 10:29 ` [PATCH 3/6] stkutil: Use struct to represent frame id Yang Gu
2010-04-26 16:41 ` Denis Kenzior
2010-04-26 10:29 ` [PATCH 4/6] test-stkutil: Refactor the implementation to test display text Yang Gu
2010-04-26 10:29 ` [PATCH 5/6] stkutil: Add parser for more time proactive commands Yang Gu
2010-04-26 10:29 ` [PATCH 6/6] test-stkutil: Add unit test for more time parser Yang Gu
2010-04-26 16:32 ` [PATCH 1/6] stkutil: Fix the assignment to minimum set Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004261039.20895.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.