From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [uq/master patch 2/5] kvm: add logging count to slots Date: Mon, 26 Apr 2010 10:47:17 -0300 Message-ID: <20100426134717.GB12814@amt.cnet> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43861 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831Ab0DZNr2 (ORCPT ); Mon, 26 Apr 2010 09:47:28 -0400 Content-Disposition: inline In-Reply-To: <4BD44F13.3070000@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Apr 25, 2010 at 05:17:55PM +0300, Avi Kivity wrote: > On 04/25/2010 04:57 PM, Jan Kiszka wrote: > > > >>It's still a good idea. The current API assumes that there will be only > >>one slot-based client (or that multiple clients will keep the refcount > >>themselves). > >> > >>After the bytemap -> multiple bitmaps conversion this can be extended to > >>each client getting its own bitmap (and therefore, s/refcount/list of > >>bitmaps/ and s/!refcount/list_empty()/). > >> > >No concerns if > > - there is an existing use case for multiple clients, at least in > > qemu-kvm > > There isn't. But I don't like hidden breakage. > > > - the logging API is consistently converted, not just extended > > (IOW, migration_log is converted to logging_count) > > migration_log needs to remain global, since we want hotplug memory > to autostart logging. > > > - someone signs he checked that current use of start/stop in qemu is > > completely symmetrical (I think to remember this used to be not the > > case, but I might be wrong) > > I remember this too. Marcelo? Don't see any guarantee that it is symmetrical. Anyway, will drop the patch from the series. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6Oep-00009r-Ab for qemu-devel@nongnu.org; Mon, 26 Apr 2010 09:47:31 -0400 Received: from [140.186.70.92] (port=38270 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6Oen-000094-UD for qemu-devel@nongnu.org; Mon, 26 Apr 2010 09:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6Oem-0002gM-EP for qemu-devel@nongnu.org; Mon, 26 Apr 2010 09:47:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14666) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6Oem-0002gC-7I for qemu-devel@nongnu.org; Mon, 26 Apr 2010 09:47:28 -0400 Date: Mon, 26 Apr 2010 10:47:17 -0300 From: Marcelo Tosatti Message-ID: <20100426134717.GB12814@amt.cnet> References: <20100423170410.914857113@amt.cnet> <20100423170645.675040544@amt.cnet> <4BD29F22.8020806@web.de> <4BD4367F.5060307@redhat.com> <4BD44A4D.4060008@web.de> <4BD44F13.3070000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BD44F13.3070000@redhat.com> Subject: [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Jan Kiszka , qemu-devel@nongnu.org, kvm@vger.kernel.org On Sun, Apr 25, 2010 at 05:17:55PM +0300, Avi Kivity wrote: > On 04/25/2010 04:57 PM, Jan Kiszka wrote: > > > >>It's still a good idea. The current API assumes that there will be only > >>one slot-based client (or that multiple clients will keep the refcount > >>themselves). > >> > >>After the bytemap -> multiple bitmaps conversion this can be extended to > >>each client getting its own bitmap (and therefore, s/refcount/list of > >>bitmaps/ and s/!refcount/list_empty()/). > >> > >No concerns if > > - there is an existing use case for multiple clients, at least in > > qemu-kvm > > There isn't. But I don't like hidden breakage. > > > - the logging API is consistently converted, not just extended > > (IOW, migration_log is converted to logging_count) > > migration_log needs to remain global, since we want hotplug memory > to autostart logging. > > > - someone signs he checked that current use of start/stop in qemu is > > completely symmetrical (I think to remember this used to be not the > > case, but I might be wrong) > > I remember this too. Marcelo? Don't see any guarantee that it is symmetrical. Anyway, will drop the patch from the series.