From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: The request_key() syscall should link an existing key to the dest keyring
Date: Mon, 26 Apr 2010 16:09:18 -0700 [thread overview]
Message-ID: <20100426160918.6f624d86.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100426154441.26028.52967.stgit@warthog.procyon.org.uk>
On Mon, 26 Apr 2010 16:44:41 +0100
David Howells <dhowells@redhat.com> wrote:
> The request_key() system call and request_key_and_link() should make a link
> from an existing key to the destination keyring (if supplied), not just from a
> new key to the destination keyring.
>
> This can be tested by:
>
> ring=`keyctl newring fred @s`
> keyctl request2 user debug:a a
> keyctl request user debug:a $ring
> keyctl list $ring
>
> If it says:
>
> keyring is empty
>
> then it didn't work. If it shows something like:
>
> 1 key in keyring:
> 1070462727: --alswrv 0 0 user: debug:a
>
> then it did.
>
I don't think I understand that description. Are you saying that the
patch switches things from the first example output into the second case?
Is the fix needed in -stable?
next prev parent reply other threads:[~2010-04-26 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 15:44 [PATCH] KEYS: The request_key() syscall should link an existing key to the dest keyring David Howells
2010-04-26 23:09 ` Andrew Morton [this message]
2010-04-27 10:15 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2010-04-26 14:59 David Howells
2010-04-28 12:04 ` Vegard Nossum
2010-04-28 14:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426160918.6f624d86.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.