From: Jens Axboe <jens.axboe@oracle.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Divyesh Shah <dpshah@google.com>,
Nauman Rafique <nauman@google.com>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Subject: Re: [PATCH] blkio: Fix another BUG_ON() crash due to cfqq movement across groups
Date: Mon, 26 Apr 2010 19:25:29 +0200 [thread overview]
Message-ID: <20100426172528.GS27497@kernel.dk> (raw)
In-Reply-To: <20100426171800.GB3372@redhat.com>
On Mon, Apr 26 2010, Vivek Goyal wrote:
> On Wed, Apr 21, 2010 at 06:19:06PM -0400, Vivek Goyal wrote:
> > o Once in a while, I was hitting a BUG_ON() in blkio code. empty_time was
> > assuming that upon slice expiry, group can't be marked empty already (except
> > forced dispatch).
> >
>
> Hi Jens,
>
> Do you have any concerns with this patch? If not, can you please include
> it.
No it's fine, I have added it. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2010-04-26 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 22:19 [PATCH] blkio: Fix another BUG_ON() crash due to cfqq movement across groups Vivek Goyal
2010-04-22 20:06 ` Divyesh Shah
2010-04-26 17:18 ` Vivek Goyal
2010-04-26 17:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426172528.GS27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dpshah@google.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.