All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] KVM MMU: make kvm_mmu_zap_page() return the number of zapped sp in total.
Date: Mon, 26 Apr 2010 14:36:09 -0300	[thread overview]
Message-ID: <20100426173609.GC21425@amt.cnet> (raw)
In-Reply-To: <4BD136FE.9060803@cn.fujitsu.com>

On Fri, Apr 23, 2010 at 01:58:22PM +0800, Gui Jianfeng wrote:
> Currently, in kvm_mmu_change_mmu_pages(kvm, page), "used_pages--" is  performed after calling
> kvm_mmu_zap_page() in spite of that whether "page" is actually reclaimed. Because root sp won't 
> be reclaimed by kvm_mmu_zap_page(). So making kvm_mmu_zap_page() return total number of reclaimed 
> sp makes more sense. A new flag is put into kvm_mmu_zap_page() to indicate whether the top page is
> reclaimed.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  arch/x86/kvm/mmu.c |   53 +++++++++++++++++++++++++++++++++++----------------
>  1 files changed, 36 insertions(+), 17 deletions(-)

Gui, 

There will be only a few pinned roots, and there is no need for
kvm_mmu_change_mmu_pages to be precise at that level (pages will be
reclaimed through kvm_unmap_hva eventually).


  reply	other threads:[~2010-04-26 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  9:33 [PATCH 1/3] KVM MMU: make kvm_mmu_zap_page() return the number of zapped sp in total Gui Jianfeng
2010-04-23  3:49 ` Xiao Guangrong
2010-04-23  5:03   ` Gui Jianfeng
2010-04-23  5:58     ` [PATCH 1/3 v2] " Gui Jianfeng
2010-04-26 17:36       ` Marcelo Tosatti [this message]
2010-05-03 13:38         ` Gui Jianfeng
2010-05-04 13:25           ` Marcelo Tosatti
2010-05-05  0:18             ` Gui Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100426173609.GC21425@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.