From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo
Date: Mon, 26 Apr 2010 16:08:06 -0300 [thread overview]
Message-ID: <20100426190806.GA8565@ghostprotocols.net> (raw)
In-Reply-To: <4BD5E298.4020506@redhat.com>
Em Mon, Apr 26, 2010 at 02:59:36PM -0400, Masami Hiramatsu escreveu:
> Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 21, 2010 at 03:56:24PM -0400, Masami Hiramatsu escreveu:
> >> Fix perf probe to use symtab only if there is no debuginfo,
> >> because debuginfo has more precise information than symtab.
> >
> > "more precise"? Wouldn't it be "more expressive", i.e. with more
> > information (parameter list with types, return type, location of
> > parameters, etc), because what is common to both have the same value,
> > i.e. the function address and size.
>
> Indeed. debuginfo has just more information than symtab, but
> symtab certainly provides precise information for symbol-address.
I applied the patch, just replaced "more precise information" with "more
information".
- Arnaldo
next prev parent reply other threads:[~2010-04-26 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 19:56 [PATCH -tip 1/4] [BUGFIX] perf tools: Initialize dso->node member in dso__new Masami Hiramatsu
2010-04-21 19:56 ` [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo Masami Hiramatsu
2010-04-26 12:48 ` Arnaldo Carvalho de Melo
2010-04-26 18:59 ` Masami Hiramatsu
2010-04-26 19:08 ` Arnaldo Carvalho de Melo [this message]
2010-04-26 19:10 ` Masami Hiramatsu
2010-04-27 12:58 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-04-21 19:56 ` [PATCH -tip 3/4] perf probe: Fix to exit callback soon after finding too many probe points Masami Hiramatsu
2010-04-27 12:58 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-04-21 19:56 ` [PATCH -tip 4/4] perf probe: Add --max-probes option Masami Hiramatsu
2010-04-27 12:59 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-04-26 14:01 ` [PATCH -tip 1/4] [BUGFIX] perf tools: Initialize dso->node member in dso__new Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426190806.GA8565@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.