From: Ralf Baechle <ralf@linux-mips.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-mips@linux-mips.org
Subject: Re: [RFC] net/sb1250: setup the pdevice within the soc code
Date: Mon, 26 Apr 2010 21:24:59 +0100 [thread overview]
Message-ID: <20100426202459.GD27656@linux-mips.org> (raw)
In-Reply-To: <20100426195229.GB22245@Chamillionaire.breakpoint.cc>
On Mon, Apr 26, 2010 at 09:52:29PM +0200, Sebastian Andrzej Siewior wrote:
> doing it within the driver does not look good.
>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> ---
> Ralf, if you fine with then I'm gonna to post it at netdev.
>
> arch/mips/sibyte/sb1250/setup.c | 55 ++++++++++++++++++
> drivers/net/sb1250-mac.c | 120 +--------------------------------------
Almost. The idea is right but the driver is also being used by the
BCM1480-based platforms. So either arch/mips/sibyte/bcm1480/setup.c
needs the same changes or - and better - you change
arch/mips/sibyte/swarm/platform.c instead. Despite the swarm in the
path name that file is being used also for all other currently supported
Sibyte platforms.
Ralf
next prev parent reply other threads:[~2010-04-26 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 19:52 [RFC] net/sb1250: setup the pdevice within the soc code Sebastian Andrzej Siewior
2010-04-26 20:24 ` Ralf Baechle [this message]
2010-04-26 20:41 ` Sebastian Andrzej Siewior
2010-04-26 21:00 ` Ralf Baechle
2010-04-26 21:07 ` [PATCH] " Sebastian Andrzej Siewior
2010-04-27 22:55 ` David Miller
2010-04-28 1:26 ` [RFC] " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426202459.GD27656@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.