Re: [PATCH 1/1] i2c-omap: add mpu wake up latency constraint in i2c

[Tony Lindgren <tony@atomide.com>]

* Kevin Hilman <khilman@deeprootsystems.com> [100426 16:27]:
> >> +	if (cpu_is_omap34xx())
> >> +		pd->set_mpu_wkup_lat = omap_i2c_set_wfc_mpu_wkup_lat;
> 
> > BTW, in your version looks like compile will break if CONFIG_ARCH_OMAP3
> > is not set.
> 
> it shouldn't since if !CONFIG_ARCH_OMAP3, cpu_is_omap34xx() is zero
> and that code will not be compiled.

Yes but look how there's no else after #ifdef CONFIG_ARCH_OMAP3..

The if (0) does not help if the code refers something that's
undefined, in this case omap_i2c_set_wfc_mpu_wkup_lat would be
undefined. So I'd assume you'll get something like when
CONFIG_ARCH_OMAP3 is not set:

error: ‘omap_i2c_set_wfc_mpu_wkup_lat’ undeclared (first use in this function)

One way to fix that would be to have #else statement with
#define omap_i2c_set_wfc_mpu_wkup_lat	NULL

Anyways, commenting on this just based on my virtual preprocessor,
I have not actually tried it :)
 
> Anyways, here's updated version which gets rid of both problems.

Thanks! Will add to i2c-omap-for-ben branch.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html