Re: [PATCH v0] Read EF_ICCID property of SIM

[Daniel Wagner <daniel.wagner@bmw-carit.de>]

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]

Hi Denis,

> > +
> > +	extract_bcd_number(data, len, number);
> > +	number[OFONO_MAX_ICCID_LENGTH] = '\0';
> > +	sim->iccid = g_strdup(number);
> > +
> > +	DBG("ICCID %s", sim->iccid);
> > +}
> > +
> 
> You might want to emit the property changed signal with the new ICCID value 
> here.

I had already the property update code there but there was some
problem with dbus. I figured that it wasn't setup correctly yet. I'll
look into that.

> >  static void sim_efphase_read_cb(const struct ofono_error *error,
> >  				const unsigned char *data, int len, void *user)
> >  {
> > @@ -1320,6 +1341,9 @@ static void sim_determine_phase(struct ofono_sim
> >  *sim)
> > 
> >  static void sim_initialize(struct ofono_sim *sim)
> >  {
> > +	sim->driver->read_file_transparent(sim, SIM_EF_ICCID_FILEID, 0, 10,
> > +					   sim_iccid_read_cb, sim);
> > +
> 
> Please use the sim file queue like EFpl does, no need to invent your own 
> solution.  

I used the ofono_sim_read function but that didn't work. On the
terminal I saw only:

CRSM=192,12258 

With read_file_transparent it is:

ofonod[2048]: Control:> AT+CRSM=176,12258,0,0,10\r
ofonod[2048]: Control:< \r\r\n+CRSM: 144,0,"989422024754212460F6"\r\n\r\nOK\r\n

> The phase check is a very specific case because we cache SIM files by 
> phase of the SIM, so it needs to be known / guessed before the rest of sim file 
> queue runs.

Thanks for the info. I'll update the patch.

daniel