diff for duplicates of <20100427090533.GZ29093@bicker> diff --git a/a/1.txt b/N1/1.txt index 29db741..bebd3b5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,7 +13,7 @@ On Tue, Apr 27, 2010 at 01:05:15AM +0200, Daniel Glöckner wrote: > - There are two gotos leading to free_sd > - #2 is after a block that allocates pdesc > - #1 is in an if (!gpio_flags) block -> - We exit early if ((desc->flags & GPIO_TRIGGER_MASK) = gpio_flags) +> - We exit early if ((desc->flags & GPIO_TRIGGER_MASK) == gpio_flags) > - Therefore (desc->flags & GPIO_TRIGGER_MASK) must be != 0 to reach #1 > - Trigger flags are added to desc->flags only after we have > successfully allocated pdesc (i.e. right before return 0) @@ -74,7 +74,7 @@ index 76be229..54922a6 100644 - if (idr_pre_get(&pdesc_idr, GFP_KERNEL)) - ret = idr_get_new_above(&pdesc_idr, - pdesc, 1, &id); -- } while (ret = -EAGAIN); +- } while (ret == -EAGAIN); - - if (ret) - goto free_mem; @@ -110,9 +110,3 @@ index 76be229..54922a6 100644 -err_out: return ret; } - - --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index cf429ea..823a421 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020100426230515.GA1388@emlix.com\0" "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [patch] gpio: potential null dereference\0" - "Date\0Tue, 27 Apr 2010 09:05:33 +0000\0" + "Date\0Tue, 27 Apr 2010 11:05:33 +0200\0" "To\0Daniel Gl\303\266ckner <dg@emlix.com>\0" "Cc\0Andrew Morton <akpm@linux-foundation.org>" Jani Nikula <ext-jani.1.nikula@nokia.com> @@ -27,7 +27,7 @@ "> - There are two gotos leading to free_sd\n" "> - #2 is after a block that allocates pdesc\n" "> - #1 is in an if (!gpio_flags) block\n" - "> - We exit early if ((desc->flags & GPIO_TRIGGER_MASK) = gpio_flags)\n" + "> - We exit early if ((desc->flags & GPIO_TRIGGER_MASK) == gpio_flags)\n" "> - Therefore (desc->flags & GPIO_TRIGGER_MASK) must be != 0 to reach #1\n" "> - Trigger flags are added to desc->flags only after we have\n" "> successfully allocated pdesc (i.e. right before return 0)\n" @@ -88,7 +88,7 @@ "-\t\t\tif (idr_pre_get(&pdesc_idr, GFP_KERNEL))\n" "-\t\t\t\tret = idr_get_new_above(&pdesc_idr,\n" "-\t\t\t\t\t\tpdesc, 1, &id);\n" - "-\t\t} while (ret = -EAGAIN);\n" + "-\t\t} while (ret == -EAGAIN);\n" "-\n" "-\t\tif (ret)\n" "-\t\t\tgoto free_mem;\n" @@ -123,12 +123,6 @@ " \tkfree(pdesc);\n" "-err_out:\n" " \treturn ret;\n" - " }\n" - " \n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + } -421a63ed43df6a0324f67b5d47de1656ad8ffabde80b0a618950a4092d9821eb +b384f793f881f1d176231169310fa9d6a6f5103ed14a398ab0f24a215d3e56e4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.